Rich Audience Bidder Adapter #3518
Conversation
|
docs PR prebid/prebid.github.io#1132 |
There was a problem hiding this comment.
Looks good to me.
@richaudience just one comment about passing in gdprConsent object to your getUserSyncs function if you want?
Thanks for >90% test coverage by the way!
modules/richAudienceBidAdapter.md
Outdated
| var adUnits = [ | ||
| { | ||
| code: 'test-div1', | ||
| sizes: [[300, 250],[300, 600]] |
There was a problem hiding this comment.
Need a comma after sizes declaration!
|
|
||
| if (bidderRequest && bidderRequest.gdprConsent) { | ||
| payload.gdpr_consent = bidderRequest.gdprConsent.consentString; | ||
| payload.gdpr = bidderRequest.gdprConsent.gdprApplies; // we're handling the undefined case server side |
There was a problem hiding this comment.
👍 Thanks for mentioning server side handling :)
modules/richAudienceBidAdapter.js
Outdated
| * @param {serverResponses} Response from the server | ||
| * @returns {Array} | ||
| */ | ||
| getUserSyncs: function (syncOptions, serverResponses) { |
There was a problem hiding this comment.
You can pass in a gdprConsent param which you can use to send consent data if needed.
I see you use the serverResponses object to achieve the same, but in the else case you could utilize this gdprConsent data if wanted.
I am unsure how RichAudience wants to handle this but though I would let you know.
Example of adapter using this: https://github.com/prebid/Prebid.js/blob/master/modules/rubiconBidAdapter.js#L464
package-lock.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "prebid.js", | |||
| "version": "2.0.0", | |||
| "version": "2.1.0-pre", | |||
There was a problem hiding this comment.
Please undo this change, no need to update package lock.
|
Hi @robertrmartinez , Thanks! |
* Rich Audience Bidder Adapter * Rich Audience Bidder Adapter * Rich Audience Bidder Adapter * Changes in UserSyncs * Changes in package-lock.json
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information