Skip to content

support gdpr for one video adapter #2981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2018

Conversation

ankur-modi
Copy link
Contributor

@ankur-modi ankur-modi commented Aug 16, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ankur-modi
Please see the inline comment when you have the chance.

Additionally, can you also put together a unit test to cover this GDPR scenario?

if (isConsentRequired(consentData)) {
bidData.regs = {
ext: {
gdpr: NUMERIC_VALUES.TRUE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify what NUMERIC_VALUES is meant to be? I've seen other adapters pass a 1 or 0 for the boolean value of the gdprApplies in this field. Is that what you want to do as well?

Currently this is going to return an undefined error, since I don't see it declared/imported from anywhere. Can you update this part?

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankur-modi Thanks for submitting the changes.

LGTM

@jsnellbaker jsnellbaker merged commit ab2c050 into prebid:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants