Added render param in Sonobi adapter #2970
Conversation
|
Hi @jaiminpanchal27 . Thanks for reviewing. Unfortunately, I can't tell why the circleCI test is broken as the link to it tells me 'something is very wrong'. |
|
@jaiminpanchal27 Unfortunately our header bidder endpoint does not support this parameter that @jeteve added in this commit. Nor was this an official submission by a member of Sonobi. How do we proceed so as to not have this committed to the next release since we did not officially approve this commit? How do we ensure future pull requests related to our adapter that are not officially submitted by a member of Sonobi have a reviewer from the Sonobi team on that pull request? |
|
Hi @bansawbanchee , should this parameter be named differently? As far as I know, this parameter has been requested by Sonobi. |
|
Can you have Spencer contact your Account Manager at Sonobi this way we can confirm why this was done? |
|
@bansawbanchee Shall we revert the change or not ? We can get this change in next prebid release on 28th Aug. |
|
Please give us 24 hrs to sort this out with the Guardian team before reverting. I will update this ticket tomorrow. |
|
Hey, @bansawbanchee yes I'm double checking with Spenc and Sonobi account mng. |
|
@jaiminpanchal27 Please revert the code changes. We are working with @jeteve and the guardian team, but this change needs to be reverted. Thanks. |
This reverts commit 5e430e3.
|
Hi @edahood-sonobi , @bansawbanchee all is sorted now! Thanks! |
) This reverts commit 5e430e3.
) This reverts commit 5e430e3.
) This reverts commit 5e430e3.
) This reverts commit 5e430e3.
) This reverts commit 5e430e3.
Type of change
Description of change
Having Sonobi in a Safeframe requires sending the 'render=safeframe' parameter to Sonobi. This makes sure it can happen.