Video support in PubMatic adapter #2807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27th March 18: Merging Prebid Master into fork branch
modules/pubmaticBidAdapter.js
Outdated
| @@ -18,6 +19,22 @@ const CUSTOM_PARAMS = { | |||
| 'profId': '', // OpenWrap Legacy: Profile ID | |||
| 'verId': '' // OpenWrap Legacy: version ID | |||
| }; | |||
| const VIDEO_CUSTOM_PARAMS = { | |||
| 'mimes': 'array', | |||
There was a problem hiding this comment.
move data-type to constant
modules/pubmaticBidAdapter.js
Outdated
| function _checkParamDataType(key, value, datatype) { | ||
| var errMsg = 'PubMatic: Ignoring param key: ' + key + ', expects ' + datatype + ', found ' + typeof value; | ||
| switch (datatype) { | ||
| case 'boolean': |
There was a problem hiding this comment.
use data-type constant
jaiminpanchal27
requested changes
Jul 9, 2018
modules/pubmaticBidAdapter.js
Outdated
| @@ -287,7 +381,17 @@ export const spec = { | |||
| referrer: utils.getTopWindowUrl(), | |||
| ad: bid.adm | |||
| }; | |||
|
|
|||
| var parsedRequest = JSON.parse(request.data); | |||
There was a problem hiding this comment.
Use let at all places
src/constants.json
Outdated
| @@ -68,5 +68,11 @@ | |||
| "SRC" : "s2s", | |||
| "DEFAULT_ENDPOINT" : "https://prebid.adnxs.com/pbs/v1/openrtb2/auction", | |||
| "SYNCED_BIDDERS_KEY": "pbjsSyncs" | |||
| }, | |||
| "DATA_TYPES": { | |||
There was a problem hiding this comment.
You can add these to your adapter.
jaiminpanchal27
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adding support for video in PubMatic adapter.
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Video params prebid.github.io#865
Other information