Skip to content

Rubicon Bid Adapter : allow multiple user syncs per prebid load #13734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025

Conversation

robertrmartinez
Copy link
Collaborator

Type of change

  • Other

Description of change

Rubicon Bid Adapter only was calling its userSync endpoint once per load of the module.

This will allow it to call multiple times whenever getUserSyncs is called.

Our sync script does its own version of throttling.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 16760124458

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 15 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.004%) to 96.253%

Files with Coverage Reduction New Missed Lines %
libraries/browsiUtils/browsiUtils.js 1 87.88%
libraries/smartyadsUtils/getAdUrlByRegion.js 1 64.29%
libraries/userAgentUtils/detailed.js 1 78.57%
modules/adxpremiumAnalyticsAdapter.js 1 83.19%
modules/eskimiBidAdapter.js 1 75.86%
modules/exadsBidAdapter.js 2 86.63%
modules/sirdataRtdProvider.js 2 84.48%
test/spec/modules/geolocationRtdProvider_spec.js 2 96.83%
modules/bidglassBidAdapter.js 4 86.54%
Totals Coverage Status
Change from base Build 16758698221: -0.004%
Covered Lines: 195475
Relevant Lines: 203085

💛 - Coveralls

@robertrmartinez
Copy link
Collaborator Author

Pull Request Test Coverage Report for Build 16760124458

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 15 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.004%) to 96.253%

hmmm

@ChrisHuie ChrisHuie self-assigned this Aug 5, 2025
@ChrisHuie ChrisHuie changed the title Rubicon Bid Adapter: Allow multiple user syncs per prebid load Rubicon Bid Adapter : allow multiple user syncs per prebid load Aug 5, 2025
@ChrisHuie ChrisHuie merged commit 8b8e7ac into master Aug 5, 2025
20 checks passed
@ChrisHuie ChrisHuie deleted the rubicon-allowMoreUserSyncs branch August 5, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants