Build sytem: allow customization of some build options (such as global name) to NPM consumers #13685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
reviewed
Jul 28, 2025
| @@ -31,6 +31,8 @@ import { _ADAGIO, getBestWindowForAdagio } from '../libraries/adagioUtils/adagio | |||
| import { getGptSlotInfoForAdUnitCode } from '../libraries/gptUtils/gptUtils.js'; | |||
| import { getBoundingClientRect } from '../libraries/boundingClientRect/boundingClientRect.js'; | |||
|
|
|||
| import {getGlobalVarName} from '../src/buildOptions.js'; | |||
There was a problem hiding this comment.
how is this different than
Prebid.js/modules/medianetBidAdapter.js
Line 23 in 7f61966
There was a problem hiding this comment.
getGlobal returns the global object (the one that has .requestBids() etc); getGlobalVarName returns the global name (e.g. 'pbjs').
Pull Request Test Coverage Report for Build 16577532621Details
💛 - Coveralls |
patmmccann
approved these changes
Jul 28, 2025
This was referenced Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This reintroduces the ability for NPM consumers to customize some build options, namely
globalVarName,defineGlobal, anddistUrlBase.The approach is:
$$PREBID_GLOBAL$$, etc) with normal function calls;customize/webpackLoader.mjs).Other information
Closes #13657