Linting: enforce no useless escape #13618

patmmccann · 2025-07-16T14:38:48Z

working on #1111

github-actions · 2025-07-16T14:39:28Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/mediakeysBidAdapter.js has 18 duplicated lines with modules/mediasniperBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

github-actions · 2025-07-16T14:40:43Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/mediakeysBidAdapter.js has 18 duplicated lines with modules/mediasniperBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

coveralls · 2025-07-16T15:16:11Z

Pull Request Test Coverage Report for Build 16603030716

Details

14 of 15 (93.33%) changed or added relevant lines in 11 files are covered.
8 unchanged lines in 7 files lost coverage.
Overall coverage increased (+0.001%) to 96.263%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
modules/outbrainBidAdapter.js	0	1	0.0%

Files with Coverage Reduction	New Missed Lines	%
modules/adxpremiumAnalyticsAdapter.js	1	83.19%
modules/bliinkBidAdapter.js	1	96.49%
modules/eskimiBidAdapter.js	1	75.86%
modules/lotamePanoramaIdSystem.js	1	89.71%
modules/mediakeysBidAdapter.js	1	94.7%
test/spec/modules/lotamePanoramaIdSystem_spec.js	1	99.62%
libraries/smartyadsUtils/getAdUrlByRegion.js	2	64.29%

Totals
Change from base Build 16602520873:	0.001%
Covered Lines:	195054
Relevant Lines:	202627

💛 - Coveralls

github-actions · 2025-07-16T19:17:34Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/mediakeysBidAdapter.js has 18 duplicated lines with modules/mediasniperBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

patmmccann · 2025-07-18T04:05:33Z

modules/beopBidAdapter.js

@@ -177,7 +177,7 @@ function buildTrackingParams(data, info, value) {
  const params = Array.isArray(data.params) ? data.params[0] : data.params;
  const pageUrl = getPageUrl(null, window);
  return {
-    pid: params.accountId ?? (data.ad?.match(/account: \“([a-f\d]{24})\“/)?.[1] ?? ''),
+    pid: params.accountId ?? (data.ad?.match(/account: “([a-f\d]{24})“/)?.[1] ?? ''),


Curly quotes are surprising

github-actions · 2025-07-24T18:16:59Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/mediakeysBidAdapter.js has 18 duplicated lines with modules/mediasniperBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

dgirardi · 2025-07-29T15:33:01Z

libraries/dspxUtils/bidderUtils.js

@@ -21,7 +21,7 @@ export function fillUsersIds(bidRequest, payload) {
      did_pubcid: 'pubcid.org',
      did_cruid: 'criteo.com',
      did_tdid: 'adserver.org',
-      did_pbmid: 'regexp:[esp\.]*pubmatic\.com',
+      did_pbmid: 'regexp:[esp\\.]*pubmatic\\.com',


this is not equivalent, do we know if it's correct? cc @onlsol

esp.pubmatic.com is the one they're looking for I believe

@dgirardi pretty clear it is wrong on further inspection

'regexp:^(?:esp\.)?pubmatic\.com$'
should catch pubmatic.com and esp.pubmatic.com, they are looking for either

the previous version does look wrong, but I don't share your confidence in asserting that what their backend does is perfectly clear :)

modules/sonobiBidAdapter.js

Co-authored-by: Demetrio Girardi <[email protected]>

github-actions · 2025-07-29T17:13:37Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/mediakeysBidAdapter.js has 18 duplicated lines with modules/mediasniperBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

github-actions · 2025-07-29T17:14:48Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/mediakeysBidAdapter.js has 18 duplicated lines with modules/mediasniperBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

fix dspx pubmatic regex

github-actions · 2025-07-29T17:24:53Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/mediakeysBidAdapter.js has 18 duplicated lines with modules/mediasniperBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

github-actions · 2025-07-29T17:25:29Z

Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):

libraries/dspxUtils/bidderUtils.js (+2 errors)

dgirardi

I have some reservations about the pubmatic regex, the newer version does look more plausible but it's also more restrictive. If you know that for example e.pubmatic.com should not be picked up then LGTM

patmmccann · 2025-07-29T19:19:32Z

yeah, i checked with a pubmatic person, those are the only two possible sources

github-actions · 2025-07-29T19:20:04Z

Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):

libraries/dspxUtils/bidderUtils.js (+2 errors)

patmmccann added 2 commits July 16, 2025 09:55

Update eslint.config.js

07d1194

Maintenance: remove useless escapes (#13617)

e5eef74

Update eslint.config.js

a2db6c0

Merge branch 'master' into lint-no-useless-escape

a7a391c

ChrisHuie requested a review from robertrmartinez July 17, 2025 12:46

ChrisHuie assigned robertrmartinez Jul 17, 2025

patmmccann commented Jul 18, 2025

View reviewed changes

Merge branch 'master' into lint-no-useless-escape

32695bd

dgirardi reviewed Jul 29, 2025

View reviewed changes

Update modules/sonobiBidAdapter.js

b37c51a

Co-authored-by: Demetrio Girardi <[email protected]>

Merge branch 'master' into lint-no-useless-escape

739b2e4

Update bidderUtils.js

90c1237

fix dspx pubmatic regex

patmmccann requested a review from dgirardi July 29, 2025 17:24

dgirardi approved these changes Jul 29, 2025

View reviewed changes

Update bidderUtils.js

9597ea0

patmmccann merged commit 18beba6 into master Jul 29, 2025
5 of 6 checks passed

patmmccann deleted the lint-no-useless-escape branch July 29, 2025 19:19

Linting: enforce no useless escape #13618

Linting: enforce no useless escape #13618

Uh oh!

Conversation

patmmccann commented Jul 16, 2025

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

coveralls commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 16603030716

Details

💛 - Coveralls

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

patmmccann Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 24, 2025

Uh oh!

dgirardi Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

patmmccann Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

patmmccann Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

dgirardi Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

dgirardi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

patmmccann commented Jul 29, 2025

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

Uh oh!

coveralls commented Jul 16, 2025 •

edited

Loading