Skip to content

Test suite: enforce no-unused-expressions in tests #13570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

patmmccann
Copy link
Collaborator

this installs a new elint helper: chai-friendly, and uses its error rule instead of the regular no-used-expressions

@patmmccann patmmccann marked this pull request as draft July 11, 2025 14:30
@patmmccann patmmccann marked this pull request as ready for review July 11, 2025 22:23
@ChrisHuie ChrisHuie requested a review from mmoschovas July 14, 2025 13:08
Copy link

Tread carefully! This PR adds 59 linter errors (possibly disabled through directives):

  • test/spec/libraries/cmp/cmpClient_spec.js (+12 errors)
  • test/spec/libraries/greedy/greedyPromise_spec.js (+7 errors)
  • test/spec/modules/1plusXRtdProvider_spec.js (+2 errors)
  • test/spec/modules/adhashBidAdapter_spec.js (+3 errors)
  • test/spec/modules/advangelistsBidAdapter_spec.js (+1 error)
  • test/spec/modules/bliinkBidAdapter_spec.js (+2 errors)
  • test/spec/modules/eclickBidAdapter_spec.js (+1 error)
  • test/spec/modules/improvedigitalBidAdapter_spec.js (+2 errors)
  • test/spec/modules/interactiveOffersBidAdapter_spec.js (+1 error)
  • test/spec/modules/intersectionRtdProvider_spec.js (+10 errors)
  • test/spec/modules/magniteAnalyticsAdapter_spec.js (+2 errors)
  • test/spec/modules/realTimeDataModule_spec.js (+5 errors)
  • test/spec/modules/tcfControl_spec.js (+5 errors)
  • test/spec/modules/visxBidAdapter_spec.js (+1 error)
  • test/spec/unit/core/bidderFactory_spec.js (+1 error)
  • test/spec/unit/secureCreatives_spec.js (+4 errors)

Copy link

Tread carefully! This PR adds 59 linter errors (possibly disabled through directives):

  • test/spec/libraries/cmp/cmpClient_spec.js (+12 errors)
  • test/spec/libraries/greedy/greedyPromise_spec.js (+7 errors)
  • test/spec/modules/1plusXRtdProvider_spec.js (+2 errors)
  • test/spec/modules/adhashBidAdapter_spec.js (+3 errors)
  • test/spec/modules/advangelistsBidAdapter_spec.js (+1 error)
  • test/spec/modules/bliinkBidAdapter_spec.js (+2 errors)
  • test/spec/modules/eclickBidAdapter_spec.js (+1 error)
  • test/spec/modules/improvedigitalBidAdapter_spec.js (+2 errors)
  • test/spec/modules/interactiveOffersBidAdapter_spec.js (+1 error)
  • test/spec/modules/intersectionRtdProvider_spec.js (+10 errors)
  • test/spec/modules/magniteAnalyticsAdapter_spec.js (+2 errors)
  • test/spec/modules/realTimeDataModule_spec.js (+5 errors)
  • test/spec/modules/tcfControl_spec.js (+5 errors)
  • test/spec/modules/visxBidAdapter_spec.js (+1 error)
  • test/spec/unit/core/bidderFactory_spec.js (+1 error)
  • test/spec/unit/secureCreatives_spec.js (+4 errors)

@patmmccann patmmccann merged commit 7b41a95 into prebid:master Jul 30, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants