Freedom Ad Network Bidder Adapter: Update to new API (master branch)

[klaussilveira]

Type of change

• Updated bidder adapter

Description of change

Updated the Freedom Ad Network adapter to speak OpenRTB directly instead of the old proprietary protocol. Now every bid request is built as a standard OpenRTB 2.x JSON payload (impressions, device, user, etc.), and every response is parsed from an OpenRTB seatbid/bid structure. It uses the recommended Prebid.js ORTB converter and follows best practices from Prebid.js.

Automated tests were also updated cover the new OpenRTB flows, adding unit tests that verify correct construction of imp[] objects, parsing of seatbid responses, and proper routing to each FAN sub‑network. In addition, we implemented user synchronization URLs (syncUrls) so that Prebid can load pixel or iframe sync endpoints for each FAN segment. Finally, consent handling was improved by mapping GDPR and CCPA signals into the OpenRTB regs and user.ext blocks, so the adapter now respects publisher‑provided consent strings and only bids when allowed.

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/fanBidAdapter.js has 55 duplicated lines with modules/mediasniperBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[klaussilveira]

Would it make sense to extract this common bid floor selection mechanism into a library or inside util?

[dgirardi]

Would it make sense to extract this common bid floor selection mechanism into a library or inside util?

ortbConverter comes with some common logic already - it's not quite the same as what you have here (imp.bidfloor is set by asking for mediaType: '*', meaning it returns what the publisher / floors provider set as a generic floor, and granular floors are set in each imp.<mediaType>.ext.bidfloor as well as in each imp.banner.format[].ext.bidfloor).

If you do prefer to look for the minimum then yes, extracting a shared library is better. Note however that a bid at the minimum floor may actually be below the floor and rejected by the priceFloors module (if it's not for the mediaType / format that had that floor).

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/fanBidAdapter.js has 55 duplicated lines with modules/mediasniperBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/fanBidAdapter.js has 36 duplicated lines with modules/mediasniperBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/fanBidAdapter.js has 36 duplicated lines with modules/mediasniperBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[klaussilveira]

@patmmccann finally had time to address your comments, thank you for the insights! Let me know if anything else is needed.

[klaussilveira]

@ChrisHuie any way I can run the e2e again for the same PR, or are some of those failing "normal"?

[patmmccann]

are and mediasniper the same company?

[klaussilveira]

Nope, just used their implementation as guidance and had not realized a generic bidFloor routine was available.

[patmmccann]

Did you notice the automated alert? Overriding text plain to json has performance issue s

[klaussilveira]

@patmmccann oops, missed that. Just pushed a fix.

Thanks for the help!

[patmmccann]

Your latest commit causes your tests to fail