Skip to content

AdPlus Analytics Adapter : initial release #13493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025

Conversation

tccdeniz
Copy link
Contributor

@tccdeniz tccdeniz commented Jul 2, 2025

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Added AdPlus Analytics Adapter

Other information

@tccdeniz tccdeniz mentioned this pull request Jul 2, 2025
10 tasks
payloadStr,
{
method: 'POST',
contentType: 'application/json',

Check warning

Code scanning / CodeQL

Application/json request type in bidder Warning

application/json request type triggers preflight requests and may increase bidder timeouts
@monis0395
Copy link
Collaborator

Hi @tccdeniz, I don't see a GLVID in the adapter code, is that intentional ?

Ref: Step 2, point 5

@tccdeniz
Copy link
Contributor Author

tccdeniz commented Jul 8, 2025

Hi @tccdeniz, I don't see a GLVID in the adapter code, is that intentional ?

Ref: Step 2, point 5

@monis0395 Normally we are registered to IAB Turkey but they didn't provide GVLID to us. If this will prevent the adapter to run, it is not an issue for us for now. So maybe you can approve and we can add it later because it can take a bit time get GVLID.

@monis0395
Copy link
Collaborator

If this will prevent the adapter to run, it is not an issue for us for now. So maybe you can approve and we can add it later because it can take a bit time get GVLID.

Since you are fine with it, please add gvlid in a later PR as It's recommended. The rest of the changes looks good to me @ChrisHuie

@ChrisHuie ChrisHuie changed the title New Analytics Adapter: AdPlus Analytics Adapter AdPlus Analytics Adapter : initial release Jul 29, 2025
@ChrisHuie ChrisHuie merged commit 95df399 into prebid:master Jul 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants