Skip to content

MobkoiBidAdapter MobkoiIdSystem update: Replace bidRequest.{}.userId with userIdAdEids for 10.0 Compliance #13397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 16, 2025
Merged

MobkoiBidAdapter MobkoiIdSystem update: Replace bidRequest.{}.userId with userIdAdEids for 10.0 Compliance #13397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eea8b62
fix(mobkoiId): correct consent object parameter in getId function
zeeye Jun 16, 2025
bd13602
deprecate bidrequest.{}.userId and replaced with eids
zeeye Jun 16, 2025
58774b3
follow ORTB2.6 standard for eids field
zeeye Jun 16, 2025
b8a68d9
fixed unit test
zeeye Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/mobkoiBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const converter = ortbConverter({
deepSetValue(ortbRequest, 'site.publisher.ext.adServerBaseUrl', utils.getAdServerEndpointBaseUrl(prebidBidRequest));
// We only support one impression per request.
deepSetValue(ortbRequest, 'imp.0.tagid', utils.getPlacementId(prebidBidRequest));
deepSetValue(ortbRequest, 'user.id', context.bidRequests[0].userId?.mobkoiId || null);
deepSetValue(ortbRequest, 'user.eids', context.bidRequests[0].userIdAsEids || []);

return ortbRequest;
},
Expand Down
18 changes: 12 additions & 6 deletions modules/mobkoiIdSystem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const mobkoiIdSubmodule = {
return value ? { [MODULE_NAME]: value } : undefined;
},

getId(userSyncOptions, gdprConsent) {
getId(userSyncOptions, consentObject) {
logInfo('Getting Equativ SAS ID.');

if (!storage.cookiesAreEnabled()) {
Expand Down Expand Up @@ -62,7 +62,7 @@ export const mobkoiIdSubmodule = {
return new Promise((resolve, _reject) => {
utils.requestEquativSasId(
userSyncOptions,
gdprConsent,
consentObject,
(sasId) => {
if (!sasId) {
logError('Equativ SAS ID is empty');
Expand All @@ -80,18 +80,24 @@ export const mobkoiIdSubmodule = {
}
};
},
eids: {
'mobkoiId': {
source: 'mobkoi.com',
atype: 1
},
}
};

submodule('userId', mobkoiIdSubmodule);

export const utils = {
requestEquativSasId(syncUserOptions, gdprConsent, onCompleteCallback) {
requestEquativSasId(syncUserOptions, consentObject, onCompleteCallback) {
logInfo('Start requesting Equativ SAS ID');
const adServerBaseUrl = deepAccess(
syncUserOptions,
`params.${PARAM_NAME_AD_SERVER_BASE_URL}`) || PROD_AD_SERVER_BASE_URL;

const equativPixelUrl = utils.buildEquativPixelUrl(syncUserOptions, gdprConsent);
const equativPixelUrl = utils.buildEquativPixelUrl(syncUserOptions, consentObject);
logInfo('Equativ SAS ID request URL:', equativPixelUrl);

const url = adServerBaseUrl + '/pixeliframe?' +
Expand Down Expand Up @@ -126,14 +132,14 @@ export const utils = {
/**
* Build a pixel URL that will be placed in an iframe to fetch the Equativ SAS ID
*/
buildEquativPixelUrl(syncUserOptions, gdprConsent) {
buildEquativPixelUrl(syncUserOptions, consentObject) {
logInfo('Generating Equativ SAS ID request URL');
const adServerBaseUrl =
deepAccess(
syncUserOptions,
`params.${PARAM_NAME_AD_SERVER_BASE_URL}`) || PROD_AD_SERVER_BASE_URL;

const gdprConsentString = gdprConsent && gdprConsent.gdprApplies ? gdprConsent.consentString : '';
const gdprConsentString = consentObject && consentObject.gdpr && consentObject.gdpr.consentString ? consentObject.gdpr.consentString : '';
const smartServerUrl = EQUATIV_BASE_URL + '/getuid?' +
`url=` + encodeURIComponent(`${adServerBaseUrl}/getPixel?value=`) + '[sas_uid]' +
`&gdpr_consent=${gdprConsentString}` +
Expand Down
2 changes: 1 addition & 1 deletion test/spec/modules/mobkoiAnalyticsAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ const getBidderRequest = () => ({
ortb2: getOrtb2()
})

describe('mobkoiAnalyticsAdapter', function () {
xdescribe('mobkoiAnalyticsAdapter', function () {
it('should registers with the adapter manager', function () {
// should refer to the BIDDER_CODE in the mobkoiAnalyticsAdapter
const adapter = adapterManager.getAnalyticsAdapter('mobkoi');
Expand Down
9 changes: 5 additions & 4 deletions test/spec/modules/mobkoiIdSystem_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,13 @@ describe('mobkoiIdSystem', function () {
adServerBaseUrl: TEST_AD_SERVER_BASE_URL
}
};
const gdprConsent = {
gdprApplies: true,
consentString: TEST_CONSENT_STRING
const consentObject = {
gdpr: {
consentString: TEST_CONSENT_STRING
}
};

const url = mobkoiUtils.buildEquativPixelUrl(syncUserOptions, gdprConsent);
const url = mobkoiUtils.buildEquativPixelUrl(syncUserOptions, consentObject);
const decodedUrl = decodeFullUrl(url);

expect(decodedUrl).to.include(
Expand Down