TRUSTX2 Bid Adapter : initial release #13044

trustXops · 2025-04-29T08:13:58Z

Type of change

Description of change

New Bidder Adapter
Maintainer: [email protected]

Test parameters for validating bids:

bidder: 'trustx2',
params: {
    placement_id: '50000',
    publisher_id: '6000',
    e2etest: true
}

github-actions · 2025-04-29T08:15:49Z

Tread carefully! This PR adds 21 linter errors and 1 linter warning (possibly disabled through directives):

modules/trustx2BidAdapter.js (+21 errors, +1 warning)

patmmccann · 2025-04-29T13:47:58Z

modules/trustx2BidAdapter.js

+ * @typedef {import('../src/adapters/bidderFactory.js').SyncOptions} SyncOptions
+ */
+
+const BIDDER_CODE = 'trustx2';


i think this is a large mistake; you should endeavor to keep your installed base. See the newspass transition from ozone to aditude backend as an example

patmmccann · 2025-04-29T13:49:30Z

modules/trustx2BidAdapter.js

+      }
+    });
+
+    // GDPR


whats with all the redundant uselles logic here? this is a bit of a mess. I think if you delete all the way down to line 150 something you get the same effect

patmmccann · 2025-04-29T13:52:04Z

modules/trustx2BidAdapter.js

+  }
+});
+
+export const spec = {


where's your gvlid; it is kind of strange to not have one and say you are gdpr compliant.

patmmccann · 2025-04-29T13:52:49Z

modules/trustx2BidAdapter.js

+   * @return {Bid[]} An array of bids which were nested inside the server.
+   */
+  interpretResponse: function(serverResponse, bidRequest) {
+    const userId = deepAccess(serverResponse, 'body.ext.userid');


use optional chaining

patmmccann · 2025-04-29T13:53:48Z

modules/trustx2BidAdapter.js

+  imp(buildImp, bidRequest, context) {
+    const impression = buildImp(bidRequest, context);
+
+    if (!impression.bidfloor) {


you should call the getFloor function explicitly

patmmccann · 2025-04-29T13:55:11Z

modules/trustx2BidAdapter.js

+
+    if (!impression.bidfloor) {
+      impression.bidfloor = bidRequest.params.bidfloor || 0;
+      impression.bidfloorcur = bidRequest.params.currency || SUPPORTED_CURRENCY;


i dont think this matches what you have in your doc bidfloorcur: 'USD'

patmmccann · 2025-04-29T13:56:01Z

modules/trustx2BidAdapter.js

+    const userId = deepAccess(serverResponse, 'body.ext.userid');
+    if (userId && config.getConfig('localStorageWriteAllowed')) {
+      if (storage.localStorageIsEnabled()) {
+        storage.setDataInLocalStorage(USER_ID_KEY, userId);


what are you trying to achieve? the shared id does this

patmmccann · 2025-04-29T13:56:14Z

modules/trustx2BidAdapter.js

+   */
+  interpretResponse: function(serverResponse, bidRequest) {
+    const userId = deepAccess(serverResponse, 'body.ext.userid');
+    if (userId && config.getConfig('localStorageWriteAllowed')) {


eliminate this getconfig

patmmccann · 2025-04-29T13:57:18Z

modules/trustx2BidAdapter.js

+    }
+
+    serverResponses.forEach(resp => {
+      const userSync = deepAccess(resp, 'body.ext.usersync');


optional chaining

patmmccann · 2025-04-29T13:58:57Z

modules/trustx2BidAdapter.js

+    return false;
+  }
+
+  const hasMediaType = containsVideoRequest(bidRequest) || hasBannerFormat(bidRequest);


it is hard to imagine this validation failing bc you listed your supported media types

patmmccann · 2025-04-29T14:05:42Z

modules/trustx2BidAdapter.js

+function isVideoValid(bidRequest) {
+  // If there's no video no need to validate
+  if (!containsVideoRequest(bidRequest)) {
+    return true;


this seems to stem from the strange && in the valid function above, if you change that to an || you can drop this validation; or just only call this function on video inventory

patmmccann · 2025-04-29T14:05:59Z

modules/trustx2BidAdapter.js

+  const params = deepAccess(bidRequest, 'params', {});
+
+  if (params && params.e2etest) {
+    return true;


why does this test bypass validations?

patmmccann · 2025-04-29T14:11:13Z

modules/trustx2BidAdapter.js

+    ...videoConfig,
+    ...videoBidParams // Bidder Specific overrides
+  };
+


isnt core doing all these vlaidations already?

Prebid.js/src/video.js

Line 70 in 14d86f9

export function validateOrtbVideoFields(adUnit, onInvalidParam) {

patmmccann · 2025-04-29T14:12:57Z

modules/trustx2BidAdapter.md

+# Additional Configuration Options
+
+## GPP/GCC Support
+TRUSTX 2.0 fully supports Global Privacy Platform (GPP) and Global Cookie Consent (GCC) standards.


what the heck is gcc?

patmmccann · 2025-04-29T14:13:40Z

modules/trustx2BidAdapter.md

+TRUSTX 2.0 fully supports Global Privacy Platform (GPP) and Global Cookie Consent (GCC) standards.
+
+## GDPR, CCPA and other Privacy Regulations
+TRUSTX 2.0 is fully compliant with GDPR, CCPA, and other global privacy regulations.


this is kind of an odd thing to say, how do you know, do you comply with gdpr outside of its geographic scope?

patmmccann · 2025-06-24T03:47:32Z

Closing as stale

trustXops added 6 commits April 25, 2025 15:02

trustx2 bidder adapter

e869238

trustx2 bidder adapter test

d9720e3

Implement storage manager

aaa63fe

Update trustx2BidAdapter.md

7b6219e

Update trustx2BidAdapter.js

baf4a41

Update labels

f4c811d

trustXops mentioned this pull request Apr 29, 2025

New Adapter: TRUSTX 2.0 prebid/prebid.github.io#6017

Draft

8 tasks

trustXops added 2 commits April 29, 2025 10:33

Fix ESLint errors and warnings

230fb6c

Update test URL

4da4426

patmmccann reviewed Apr 29, 2025

View reviewed changes

patmmccann requested changes Apr 29, 2025

View reviewed changes

ChrisHuie assigned patmmccann Apr 29, 2025

ChrisHuie added the feature label Apr 29, 2025

ChrisHuie changed the title ~~TRUSTX 2.0 Bidder Adapter~~ TRUSTX2 Bid Adapter : initial release Apr 29, 2025

trustXops marked this pull request as draft May 9, 2025 08:07

patmmccann removed their assignment May 30, 2025

patmmccann closed this Jun 24, 2025

+                    }
+                  });
+                  // GDPR

TRUSTX2 Bid Adapter : initial release #13044

TRUSTX2 Bid Adapter : initial release #13044

Uh oh!

Conversation

trustXops commented Apr 29, 2025

Type of change

Description of change

Uh oh!

github-actions bot commented Apr 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

patmmccann Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

patmmccann Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

patmmccann commented Jun 24, 2025

Uh oh!

Uh oh!

patmmccann Apr 29, 2025 •

edited

Loading

patmmccann Apr 29, 2025 •

edited

Loading