Skip to content

Valuad Bid Adapter: initial release #13016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

natanavra
Copy link

Type of change

  • New bidder adapter

Description of change

Initial release of Valuad's bid adapter

{
  bidder: 'valuad',
  params: {
      placementId: '00000',
  }
}

Other information

Documentation PR: prebid/prebid.github.io#6001

Copy link

Tread carefully! This PR adds 6 linter errors (possibly disabled through directives):

  • modules/valuadBidAdapter.js (+6 errors)

@natanavra
Copy link
Author

natanavra commented Apr 22, 2025

Please note that tests are failing to master's tests currently being broken

Also, are new bid adapters still accepted on prebid 8 and 7?

@ChrisHuie
Copy link
Collaborator

Please note that tests are failing to master's tests currently being broken

Also, are new bid adapters still accepted on prebid 8 and 7?

No. We currently do not update those versions. Sorry

@natanavra
Copy link
Author

Hi @robertrmartinez, anything missing for this PR to be approved?
Thanks!

@natanavra natanavra changed the title Valuad Bid Adapater: initial release Valuad Bid Adapter: initial release May 7, 2025
@natanavra
Copy link
Author

@robertrmartinez my bad, the tests were failing due to global scope pollution, this is now fixed and build is successful.

@robertrmartinez
Copy link
Collaborator

robertrmartinez commented May 11, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants