-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Valuad Bid Adapter: initial release #13016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Tread carefully! This PR adds 6 linter errors (possibly disabled through directives):
|
Please note that tests are failing to master's tests currently being broken Also, are new bid adapters still accepted on prebid 8 and 7? |
No. We currently do not update those versions. Sorry |
Hi @robertrmartinez, anything missing for this PR to be approved? |
@robertrmartinez my bad, the tests were failing due to global scope pollution, this is now fixed and build is successful. |
I will take a look at this and get it reviewed this week sorry for the delay
…On Sun, May 11, 2025 at 2:01 AM natanavra ***@***.***> wrote:
*natanavra* left a comment (prebid/Prebid.js#13016)
<#13016 (comment)>
@robertrmartinez <https://github.com/robertrmartinez> my bad, the tests
were failing due to global scope pollution, this is now fixed and build is
successful.
—
Reply to this email directly, view it on GitHub
<#13016 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKTKOUY6FKQDFLCIGC3UGL254GXZAVCNFSM6AAAAAB3TCIH5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNRZGY2DCNBUGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Type of change
Description of change
Initial release of Valuad's bid adapter
Other information
Documentation PR: prebid/prebid.github.io#6001