-
Notifications
You must be signed in to change notification settings - Fork 2.2k
VRTCAL Bid Adapter : updated user sync support #10579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
modules/vrtcalBidAdapter.js
Outdated
const usPrivacy = `&us_privacy=${encodeURIComponent(uspConsent)}`; | ||
const gpp = gppConsent.gppString ? gppConsent.gppString : ''; | ||
const gppSid = Array.isArray(gppConsent.applicableSections) ? gppConsent.applicableSections.join(',') : ''; | ||
var vrtcalSyncURL = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, can you change this var
to a let
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjustment made
Hi @vrtcal-dev Is there a way to test your bidder with a locally hosted test page? I was trying to test the updates, however I encountered a CORS error with the endpoint due to the locally hosted hello_world.html I modified. I saw the iframe userSync URL try to execute, but it was canceled by the browser. |
Thank you for your screenshot as it was helpful in us determining why you were getting CORS errors for our bidder at all. You were seeing this due to the server back end not setting the CORS * allowance for non-bid returns. This has been corrected, so you should be able to retest without any CORS errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you happened to see my deleted comment, please ignore - there was an issue with my Chrome browser at the time.
LGTM
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information