Skip to content

VRTCAL Bid Adapter : updated user sync support #10579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2023
Merged

VRTCAL Bid Adapter : updated user sync support #10579

merged 2 commits into from
Oct 12, 2023

Conversation

vrtcal-dev
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

const usPrivacy = `&us_privacy=${encodeURIComponent(uspConsent)}`;
const gpp = gppConsent.gppString ? gppConsent.gppString : '';
const gppSid = Array.isArray(gppConsent.applicableSections) ? gppConsent.applicableSections.join(',') : '';
var vrtcalSyncURL = ''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, can you change this var to a let?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjustment made

@ChrisHuie ChrisHuie changed the title VRTCAL -- Updated User Sync Support VRTCAL Bid Adapter : updated user sync support Oct 10, 2023
@jsnellbaker
Copy link
Collaborator

Hi @vrtcal-dev

Is there a way to test your bidder with a locally hosted test page? I was trying to test the updates, however I encountered a CORS error with the endpoint due to the locally hosted hello_world.html I modified.

I saw the iframe userSync URL try to execute, but it was canceled by the browser.

Screen Shot 2023-10-11 at 1 13 39 PM

@vrtcal-dev
Copy link
Contributor Author

Hi @vrtcal-dev

Is there a way to test your bidder with a locally hosted test page? I was trying to test the updates, however I encountered a CORS error with the endpoint due to the locally hosted hello_world.html I modified.

I saw the iframe userSync URL try to execute, but it was canceled by the browser.

Thank you for your screenshot as it was helpful in us determining why you were getting CORS errors for our bidder at all. You were seeing this due to the server back end not setting the CORS * allowance for non-bid returns. This has been corrected, so you should be able to retest without any CORS errors.

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you happened to see my deleted comment, please ignore - there was an issue with my Chrome browser at the time.

LGTM

@jsnellbaker jsnellbaker merged commit de82bae into prebid:master Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants