Trafficgate Bid Adapter: move to OpenRTB Converter #10007
Conversation
|
Hello. When this PR will be merged and released? |
|
Hi I will review this soon! Sorry for the delay. |
|
Hello. When this PR will be merged and released? |
modules/trafficgateBidAdapter.js
Outdated
| at: 1, | ||
| }) | ||
| const bid = context.bidRequests[0]; | ||
| if (bid.params.coppa) { |
There was a problem hiding this comment.
I believe this should be taken from config.getConfig('coppa') as priority, which I believe the ortbconverter may already grab it.
So this might need to be changed to a conditional only set if req.regs.coppa not already set
There was a problem hiding this comment.
Okey. I removed it.
modules/trafficgateBidAdapter.js
Outdated
| if (bid.params.coppa) { | ||
| deepSetValue(req, 'regs.coppa', 1); | ||
| } | ||
| if (bid.params.doNotTrack) { |
There was a problem hiding this comment.
also this is something prebid willl set based on several checks here:
https://github.com/prebid/Prebid.js/blob/master/src/fpd/enrichment.js#L99
https://github.com/prebid/Prebid.js/blob/master/src/utils.js#L938
So I think not overwriting is the right thing to do here
There was a problem hiding this comment.
I removed this too.
|
Done! |
* Trafficgate Bid Adapter: move to OpenRTB Converter * Trafficgate Bid Adapter: move to OpenRTB Converter * Trafficgate Bid Adapter: move to OpenRTB Converter --------- Co-authored-by: vlad <[email protected]>
* Trafficgate Bid Adapter: move to OpenRTB Converter * Trafficgate Bid Adapter: move to OpenRTB Converter * Trafficgate Bid Adapter: move to OpenRTB Converter --------- Co-authored-by: vlad <[email protected]>
* Trafficgate Bid Adapter: move to OpenRTB Converter * Trafficgate Bid Adapter: move to OpenRTB Converter * Trafficgate Bid Adapter: move to OpenRTB Converter --------- Co-authored-by: vlad <[email protected]>
prebid/prebid.github.io#4606
Type of change
Yes
Description of change
Rewrite adapter on OpenRTB Converter for receiving an OpenRTB request on the server and response with BidResponse OpenRTB
Banner 300x250px
Video 640x480px
Be sure to test the integration with your adserver using the Hello World sample page. -->
var adUnits = [{
code: 'div-gpt-ad-1460505748561-0',
sizes: [[300, 250]], // a display size
mediaTypes: {
banner: {
sizes: [[300, 250]],
}
},
bids: [{
bidder: 'trafficgate',
params: {
placementId: '16',
host: 'bidscube',
test: 1
}
}]
}];