double bidding when using adServer: { params: { , with video module

[spormeon]

Type of issue

seems to be a bug

Description

if we use adServer { params:{ there seems to be a double bid bug going on, using params such as these:

adServer: {
vendorCode: 'gam',
// url: 'https://pubads.g.doubleclick.net/gampad/ads?',
params: {
iu: adysisSlot,
description_url: encodeURIComponent(window.location.href),
// description_url: 'https%3A%2F%2Fgolfwrx.com',
output: 'vast',
url: encodeURIComponent(window.location.href),
// url: 'https%3A%2F%2Fgolfwrx.com',
// pageUrl: encodeURIComponent(window.location.href),
// vpa: 'auto',
// vpmute: '1',
// vpos: 'preroll',
sz: '1x1|48x27|96x54|300x169|300x197|301x170|312x176|320x100|320x180|326x184|341x192|353x250|360x203|361x203|362x204|363x205|375x211|377x212|400x225|400x300|414x233|550x310|600x338|640x360|640x390|640x480|1280x720',
min_ad_duration: '5000',
max_ad_duration: '60000',
ciu_sz: '728x90,468x60,300x250',
},

if we use the exactly the same seup but use the baseAdTagUrl, there is no "double bid":

adServer: {
vendorCode: 'gam',
baseAdTagUrl: 'https://pubads.g.doubleclick.net/gampad/ads?iu=/21775744923/external/single_preroll_skippable&sz=640x480&ciu_szs=300x250%2C728x90&gdfp_req=1&output=vast&unviewed_position_start=1&env=vp&impl=s&correlator='
},

Setup uses "bid scheduling" to get first bid of offset: 0, followng bids are a random number between 10 & 25:

adyjs.onEvent('videoContentLoaded', (e) => {
// reset the offset when media is loaded
adyjs.requestBids(adUnits);
midrollOffset = 0;
});

    adyjs.onEvent('videoTime', (e) => {
      // when the video reaches the midroll, request bids and update the offset.
      if (e.position >= midrollOffset) {
        adyjs.requestBids(adUnits);
        midrollOffset += midRollTimeDifference;
      }
    });

Steps to reproduce

double bid, 1 after another, 1 sec apart, auction ID is the same due to the floors potential bug open on #9710

also in debug:

USING SAME SETUP WITH BaseAdTagUrl: only 1 first bid:

Test page

its in action on the test page @ChrisHuie has, as the params are being used there

Expected results

single bid on first auction

Actual results

double bid on first auction

Platform details

V7.41.0 , mac, chrome

Other information

[spormeon]

there seems to be another bug tied to this, if i swap over to using the baseAdTag ( reconstruct it from the params I use), then the PPID mech that was developed in #8151 doesnt append the ppid to the baseAdTag url

[spormeon]

i think i've fixed this, so can close out i guess, but the PPID thing is still there

[patmmccann]

not sure what you are referring to as the 'ppid thing' but closing as you suggest. Thanks!