Skip to content

seeing floors stopping auction id change, with video module #9710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spormeon opened this issue Mar 24, 2023 · 9 comments
Closed

seeing floors stopping auction id change, with video module #9710

spormeon opened this issue Mar 24, 2023 · 9 comments
Labels

Comments

@spormeon
Copy link

Type of issue

potential bug, not sure

Description

I'm trying to do a simple test with floors and the video module but i'm seeing that when i add floors, the auction id stops changing. I'm not 100% sure if this is a prob or if i've ballzed up something, i'm basically just trying to set a simple one price floor for video and using this, should this work?

Steps to reproduce

if floors setting addd, for basic floor, auction Id replicates, take it out auction ID changes in each bid
floors: {
auctionDelay: 100,
enforcement: {
enforceJS: false,
floorDeals: true,
},
floorMin: 0.05,
data: {
currency: 'GBP',
skipRate: 5,
modelVersion: 'Sports Ad Unit Floors',
schema: {
fields: ['mediaType']
},
values: {
'video': 0.50
}
}
},

Test page

@ChrisHuie has the test page

Expected results

auction ID changing

Actual results

auction ID replicates on bids

Platform details

v7.41.0, mac, chrome

Other information

seeing_floors_stopping_auction_id_change__with_video_module_·Issue__9702·_prebid_Prebid_js_🔊

pubmatic shows the floors info:
DevTools_-_cdn_adysis_com_VideoDemo_DemoSite_pages_NewVideoModuleNeuwoGolf_html

no prebid errors thrown

@patmmccann
Copy link
Collaborator

@spormeon are you able to confirm the issue without using Professor Prebid? Is it possible PP is reporting the wrong value and js is working fine?

@spormeon
Copy link
Author

ye here you go:
DevTools_-_cdn_adysis_com_VideoDemo_DemoSite_pages_NewVideoModuleNeuwoGolf_html

@spormeon
Copy link
Author

Update on this, I've set this to a complete bare bones min floors setup but the auction ID continues to repeat as before, I dont see whats making any differnce at all here:

var floorPrices = {
currency: 'GBP',
floor: 0.50
// skipRate: 0.2, // Set skip rate for video media type 0-1 0 no skipping, 1 all ads skipped
// modelVersion: '1.0' // Set floor price model version for video media type
};

setConfig:
floors: {
auctionDelay: 200,
// enforcement: {
// enforceJS: false,
// floorDeals: true,
// },
enabled: true,
// Set global floor prices for all ad units
global: floorPrices,
// Set ad unit specific floor prices
// mediaType: {
// video: floorPrices // Set floor prices specifically for video media type
// }
},

@spormeon
Copy link
Author

also tried setting floors at adUnit level with the blank floors array in setConfig, same behaviour, auction ID repeats

@bretg bretg assigned karimMourra and unassigned ChrisHuie Apr 27, 2023
@patmmccann patmmccann moved this from Needs OP to Ready for Dev in Prebid.js Tactical Issues table May 22, 2023
@patmmccann
Copy link
Collaborator

marking as ready for dev as we have test page and this is now documented to not rely on PP reporting issues

@patmmccann patmmccann added the bug label May 22, 2023
@karimMourra
Copy link
Collaborator

karimMourra commented May 24, 2023

Based on my debugging, this appears to be unrelated to the video module.
I was able to reproduce this bug without even using the video module. Also, if I use the video module without the priceFloors module, the bug does not reproduce. I suggest closing and opening a bug for the priceFloors module.

The Video Module integration example called bidRequestScheduling makes a bidRequest after every 10 seconds of content. The following screenshot shows that the auction IDs are different
Screen Shot 2023-05-24 at 10 13 47 AM

@karimMourra karimMourra removed their assignment May 24, 2023
@dgirardi
Copy link
Collaborator

The problem is an invalid argument passed to requestBids, that - because it's always the same object - ends up forcing the auction ID from the second invocation onwards:

Image

If you use addAdUnits, there's no need to pass adUnits to requestBids again; and if you do pass them, it should have the form requestBids({adUnits}) - reference.

@patmmccann
Copy link
Collaborator

@spormeon we wasted a lot of overhead to identify a simple fix because of your caginess around test pages. We don't plan to support that again.

@github-project-automation github-project-automation bot moved this from Ready for Dev to Done in Prebid.js Tactical Issues table Jul 12, 2023
@spormeon
Copy link
Author

its from the video module files:
bidRequestScheduling_html_—_Prebid_js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

5 participants