Skip to content

onBidWon sometimes runs on s2s bids #9515

@dgirardi

Description

@dgirardi

Type of issue

Bug / Improvement

Description

An adapter's onBidWon handler will run on s2s bids if it's included in the bundle, but obviously not if it isn't. Besides the difference in behavior in itself, it's likely that not all adapters can actually accept an s2s bid in their onBidWon handler: they may expect it to be one that they generated. For example:

onBidWon: function(data) {
data.winNotification.forEach(function(unitWon) {
let adPartnerBidWonUrl = buildUrl({
protocol: ENDPOINT_PROTOCOL,
hostname: ENDPOINT_DOMAIN,
pathname: unitWon.path
});
if (unitWon.method === 'POST') {
spec.postRequest(adPartnerBidWonUrl, JSON.stringify(unitWon.data));
}
});
return true;
},

Proposal

The new onBidBillable method to be introduced for #4494 will be invoked only for client side bids.
Starting from version 8, onBidWon will also be invoked only for client-side bids.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions