Skip to content

fix: escape style object value in precompile transform #4795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

marvinhagemeister
Copy link
Member

We didn't escape the value when passing an object to style when using Deno's precompile transform. This does not affect other JSX transforms.

Copy link

github-actions bot commented Jun 11, 2025

📊 Tachometer Benchmark Results

Summary

A summary of the benchmark results will show here once they finish.

Results

The full results of your benchmarks will show here once they finish.

tachometer-reporter-action v2 for CI

Copy link

github-actions bot commented Jun 11, 2025

Size Change: -1 B (0%)

Total Size: 78.7 kB

Filename Size Change
jsx-runtime/dist/jsxRuntime.js 977 B -1 B (-0.1%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.15 kB
compat/dist/compat.mjs 4.08 kB
compat/dist/compat.module.js 4.08 kB
compat/dist/compat.umd.js 4.21 kB
debug/dist/debug.js 3.82 kB
debug/dist/debug.mjs 3.82 kB
debug/dist/debug.module.js 3.82 kB
debug/dist/debug.umd.js 3.9 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 274 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.75 kB
dist/preact.min.js 4.77 kB
dist/preact.min.module.js 4.78 kB
dist/preact.min.umd.js 4.8 kB
dist/preact.mjs 4.76 kB
dist/preact.module.js 4.76 kB
dist/preact.umd.js 4.8 kB
hooks/dist/hooks.js 1.54 kB
hooks/dist/hooks.mjs 1.57 kB
hooks/dist/hooks.module.js 1.57 kB
hooks/dist/hooks.umd.js 1.61 kB
jsx-runtime/dist/jsxRuntime.mjs 952 B
jsx-runtime/dist/jsxRuntime.module.js 952 B
jsx-runtime/dist/jsxRuntime.umd.js 1.05 kB
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 477 B
test-utils/dist/testUtils.module.js 477 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@marvinhagemeister marvinhagemeister merged commit fd1f38d into v10.x Jun 11, 2025
11 of 12 checks passed
@marvinhagemeister marvinhagemeister deleted the 10.x-precompile-style branch June 11, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants