Skip to content

Only one toLowerCase invoke #4764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Only one toLowerCase invoke #4764

merged 2 commits into from
May 16, 2025

Conversation

JoviDeCroock
Copy link
Member

No description provided.

Copy link

github-actions bot commented May 14, 2025

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -0% - +0% (-3.09ms - +5.01ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.02ms - +0.03ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +2% (-0.03ms - +1.75ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +2% (-0.17ms - +0.32ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -3% - +2% (-1.98ms - +1.47ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +5% (-0.10ms - +0.10ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +1% (-0.66ms - +0.28ms)
    preact-local vs preact-main
  • update10th1k: faster ✔ 2% - 7% (0.74ms - 2.21ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +1% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +9% (-0.24ms - +0.59ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +1% (-0.01ms - +0.02ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -4% - +3% (-0.05ms - +0.03ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +1% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - -0% (-0.01ms - -0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local1007.71ms - 1011.95ms-unsure 🔍
-0% - +0%
-3.09ms - +5.01ms
preact-main1005.41ms - 1012.33msunsure 🔍
-0% - +0%
-5.01ms - +3.09ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.18ms - 19.18ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.18ms - 19.18msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.54ms - 16.58ms-unsure 🔍
-0% - +0%
-0.02ms - +0.03ms
preact-main16.53ms - 16.57msunsure 🔍
-0% - +0%
-0.03ms - +0.02ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.54ms - 1.55ms-unsure 🔍
-0% - +1%
-0.00ms - +0.01ms
preact-main1.54ms - 1.54msunsure 🔍
-1% - +0%
-0.01ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local72.08ms - 73.45ms-unsure 🔍
-0% - +2%
-0.03ms - +1.75ms
preact-main71.33ms - 72.47msunsure 🔍
-2% - +0%
-1.75ms - +0.03ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local6.85ms - 7.46ms-unsure 🔍
-3% - +9%
-0.24ms - +0.59ms
preact-main6.69ms - 7.26msunsure 🔍
-8% - +3%
-0.59ms - +0.24ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.18ms - 16.52ms-unsure 🔍
-1% - +2%
-0.17ms - +0.32ms
preact-main16.11ms - 16.45msunsure 🔍
-2% - +1%
-0.32ms - +0.17ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.78ms - 3.81ms-unsure 🔍
-0% - +1%
-0.01ms - +0.02ms
preact-main3.78ms - 3.80msunsure 🔍
-1% - +0%
-0.02ms - +0.01ms
-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local74.23ms - 76.61ms-unsure 🔍
-3% - +2%
-1.98ms - +1.47ms
preact-main74.43ms - 76.92msunsure 🔍
-2% - +3%
-1.47ms - +1.98ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.99ms - 2.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main2.99ms - 2.99msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local26.90ms - 27.66ms-unsure 🔍
-3% - +1%
-0.80ms - +0.27ms
preact-main27.18ms - 27.92msunsure 🔍
-1% - +3%
-0.27ms - +0.80ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local35.15ms - 36.72ms-unsure 🔍
-3% - +4%
-0.96ms - +1.28ms
preact-main34.98ms - 36.57msunsure 🔍
-4% - +3%
-1.28ms - +0.96ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local30.60ms - 31.73ms-unsure 🔍
-5% - +0%
-1.58ms - +0.02ms
preact-main31.38ms - 32.50msunsure 🔍
-0% - +5%
-0.02ms - +1.58ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local25.84ms - 26.92ms-unsure 🔍
-4% - +2%
-1.12ms - +0.42ms
preact-main26.17ms - 27.28msunsure 🔍
-2% - +4%
-0.42ms - +1.12ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local26.23ms - 27.38ms-unsure 🔍
-3% - +3%
-0.85ms - +0.85ms
preact-main26.18ms - 27.42msunsure 🔍
-3% - +3%
-0.85ms - +0.85ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local22.45ms - 23.49ms-unsure 🔍
-4% - +2%
-0.97ms - +0.55ms
preact-main22.62ms - 23.73msunsure 🔍
-2% - +4%
-0.55ms - +0.97ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 150
  • Built by: CI #4695
  • Commit: d20930e

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.03ms - 2.19ms-unsure 🔍
-5% - +5%
-0.10ms - +0.10ms
preact-main2.04ms - 2.18msunsure 🔍
-5% - +5%
-0.10ms - +0.10ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.18ms - 1.24ms-unsure 🔍
-4% - +3%
-0.05ms - +0.03ms
preact-main1.19ms - 1.26msunsure 🔍
-3% - +4%
-0.03ms - +0.05ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.91ms - 34.37ms-unsure 🔍
-2% - +1%
-0.66ms - +0.28ms
preact-main33.92ms - 34.75msunsure 🔍
-1% - +2%
-0.28ms - +0.66ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.24ms - 1.25ms-unsure 🔍
-0% - +1%
-0.00ms - +0.01ms
preact-main1.24ms - 1.24msunsure 🔍
-1% - +0%
-0.01ms - +0.00ms
-
update10th1k
  • Browser: chrome-headless
  • Sample size: 130
  • Built by: CI #4695
  • Commit: d20930e

duration

VersionAvg timevs preact-localvs preact-main
preact-local30.44ms - 31.41ms-faster ✔
2% - 7%
0.74ms - 2.21ms
preact-main31.85ms - 32.95msslower ❌
2% - 7%
0.74ms - 2.21ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.95ms - 2.95ms-unsure 🔍
-0% - -0%
-0.01ms - -0.00ms
preact-main2.96ms - 2.96msunsure 🔍
+0% - +0%
+0.00ms - +0.01ms
-

tachometer-reporter-action v2 for CI

Copy link

github-actions bot commented May 14, 2025

Size Change: 0 B

Total Size: 78.6 kB

Filename Size Change
dist/preact.min.module.js 4.77 kB -1 B (-0.02%)
dist/preact.min.umd.js 4.8 kB -1 B (-0.02%)
dist/preact.mjs 4.76 kB +1 B (+0.02%)
dist/preact.module.js 4.76 kB +1 B (+0.02%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.15 kB
compat/dist/compat.mjs 4.08 kB
compat/dist/compat.module.js 4.08 kB
compat/dist/compat.umd.js 4.21 kB
debug/dist/debug.js 3.82 kB
debug/dist/debug.mjs 3.82 kB
debug/dist/debug.module.js 3.82 kB
debug/dist/debug.umd.js 3.9 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 274 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.75 kB
dist/preact.min.js 4.77 kB
dist/preact.umd.js 4.8 kB
hooks/dist/hooks.js 1.54 kB
hooks/dist/hooks.mjs 1.57 kB
hooks/dist/hooks.module.js 1.57 kB
hooks/dist/hooks.umd.js 1.61 kB
jsx-runtime/dist/jsxRuntime.js 978 B
jsx-runtime/dist/jsxRuntime.mjs 952 B
jsx-runtime/dist/jsxRuntime.module.js 952 B
jsx-runtime/dist/jsxRuntime.umd.js 1.05 kB
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 477 B
test-utils/dist/testUtils.module.js 477 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoviDeCroock JoviDeCroock merged commit a4affdc into main May 16, 2025
12 checks passed
@JoviDeCroock JoviDeCroock deleted the try-perf-improvement-props branch May 16, 2025 05:19
@JoviDeCroock JoviDeCroock mentioned this pull request May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants