revert: Bring back strict-equality bailout for children even w/ context updates #4724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt updates Reverts a portion of #4048
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
|
Size Change: -5 B (-0.01%) Total Size: 78.5 kB
ℹ️ View Unchanged
|
|
Unfortunately I'm really struggling to come up with a test case that reproduces the behavior minimally. If anyone has suggestions, would love to hear them as perhaps I'm tunnel visioning here. Tentatively opening this up for review as tests in |
JoviDeCroock
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts a portion of #4048
This has been a bit of an annoyance in
preact-isofor a while; essentially, when navigating between async routes, our router will render both children (outgoing & incoming) once before swapping over to just the incoming. Because of #4048, which altered this conditional from(!c._force && c.sCU() == false) || new._orig == old._origto!c._force && (c.sCU() === false || new orig == old.orig), the outgoing route would now be rerendered with the new context value. Rerenders aren't great but this was specifically problematic as it was rerendering with location data that component should never see in the first place which can result in a few weird surprises for users.Jovi & I had originally talked a bit about this prior to preactjs/preact-iso#37, but we decided to just comment out the failing tests with a note as we only caught it long after the fact. It seems part of the prior PR can be safely reverted though, keeping the tests the user added.