Skip to content

types: Add auxClick event types #4672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2025
Merged

types: Add auxClick event types #4672

merged 2 commits into from
Feb 16, 2025

Conversation

rschristian
Copy link
Member

From the project referenced here: preactjs/preact-www#1240 (comment)

One thing worth calling out here is that the spec recently (-ish, 4 years ago) changed this event from extending a MouseEvent to a PointerEvent and only Chrome/Chromium-based browsers support this yet. Do we want to make this a MouseEvent with a note to change this in the future, or use PointerEvent now (as this PR does)? I have no opinions one way or the other.

Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it when specs are in flux, todo sounds fine

@rschristian rschristian merged commit 34e9715 into main Feb 16, 2025
4 checks passed
@rschristian rschristian deleted the types/aux-click branch February 16, 2025 07:18
@JoviDeCroock JoviDeCroock mentioned this pull request Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants