fix: Reverts fork-ts-checker version bump #1567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7b43b8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Seems like the pnpm ci is broken in general, nothing to do with this PR |
|
hmm, that's weird, it was passing on master |
ForsakenHarmony
approved these changes
May 29, 2021
|
Oops, realized you're talking about the CI. Looks to be something with TS 4.3.2, which was just released. Not sure why that breaks things though? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix / partial revert of #1465
Did you add tests for your changes?
No
Summary
fork-ts-checker-webpack-pluginwas broken as of v3.2.0, as it was upgraded a couple major versions without updating its config.Unfortunately versions >= 5 seem to entirely lock our build process. I spent an hour trying to hunt down the reason but no luck. Hangs with no errors or logs to check.
Reverting at least allows TS users to have a functional build tool.
Does this PR introduce a breaking change?
No