Skip to content

Release/v0.10.20 #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 31, 2024
Merged

Release/v0.10.20 #612

merged 6 commits into from
Jul 31, 2024

Conversation

Mudiwa66
Copy link
Contributor

CAPI changes


self.call_command("Event", 6)

self.assertEqual(Event.objects.count(), 6)

def test_delete_messages(self):
running_month = timezone.now() - relativedelta(months=12, hour=12)
running_month = timezone.now() - relativedelta(days=365, hour=12)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikh360 I'm not sure how to handle leap years or months ending on the 29/30th

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine for now

@Mudiwa66 Mudiwa66 requested a review from erikh360 July 31, 2024 12:56
Copy link
Contributor

@erikh360 erikh360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment


for i in range(12):
self.create_record(Message, i, running_month)
running_month = running_month + relativedelta(months=1)
running_month = running_month + relativedelta(days=31)
print(f" running month: {running_month}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the print please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the print, I'm going to merge now.

@Mudiwa66 Mudiwa66 merged commit 3369830 into develop Jul 31, 2024
1 check passed
@Mudiwa66 Mudiwa66 deleted the release/v0.10.20 branch July 31, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants