Pods: with seaworthy tests #69
Conversation
example/fixtures.py
Outdated
|
|
||
| def wait_for_start(self, docker_helper, container): | ||
| # No real way to know when Nginx is ready. Wait a short moment. | ||
| time.sleep(0.5) |
There was a problem hiding this comment.
A better option may be to make some dummy requests against Nginx.
There was a problem hiding this comment.
Does it have a status page we can hit?
| MatchesPsTree('nginx', nginx_worker_args), | ||
| ])) | ||
|
|
||
| def test_nginx_access_logs(self, nginx_container, web_container): |
There was a problem hiding this comment.
Whether a test is "for" the Nginx container or for the web/gunicorn container is kinda hard to say, since they work together. It's possible that it makes more sense for all the tests for headers and such to be in TestNginx instead of TestWeb, but I'm not sure.
example/fixtures.py
Outdated
| # FIXME: there are probably better ways to skip these tests | ||
| if pods: | ||
| if request.fixturename in ['web_only_container', 'single_container']: | ||
| pytest.skip() |
There was a problem hiding this comment.
Maybe we can tie into collection hooks or something?
https://docs.pytest.org/en/latest/writing_plugins.html#hook-function-validation-and-execution
example/fixtures.py
Outdated
|
|
||
| def wait_for_start(self, docker_helper, container): | ||
| # No real way to know when Nginx is ready. Wait a short moment. | ||
| time.sleep(0.5) |
There was a problem hiding this comment.
Does it have a status page we can hit?
| if pods: | ||
| if request.fixturename in [ | ||
| 'web_only_container', 'single_container']: | ||
| pytest.skip() |
There was a problem hiding this comment.
Maybe pytest.skip("these tests don't make sense for pods") and something equivalent in the other branch?
|
Closing these pods PRs as I've learnt a lot about this stuff since then and would do this differently. |
No description provided.