Fix very old lazer replays failing to decode #33969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
commented
Jul 1, 2025
Comment on lines
+300
to
+301
| // notably this cannot just be `(int)Parsing.ParseFloat(split[0])`, because that can lose information | ||
| // (`float` numbers have 24 bits of significand precision, which is not enough to accurately represent every possible value of `int`). |
There was a problem hiding this comment.
claim experimentally backed by
for (int i = int.MinValue; i + 1 != int.MinValue; i++)
{
if (i % 10000000 == 0)
Console.WriteLine(i);
string s = i.ToString();
float f = float.Parse(s);
if ((int)f != i)
throw new InvalidOperationException($"nope (float={(int)f} int={i})");
}output
Unhandled exception. System.InvalidOperationException: nope (float=-2147483648 int=-2147483647)
at Program.<Main>$(String[] args) in /Users/bdach/Documents/Work/tools/Sketchpad/Sketchpad/Program.cs:line 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://discord.com/channels/188630481301012481/1097318920991559880/1389240665061462047.
I hope this was worth it.