Ensure global leaderboard state matches beatmap when loading player

[bdach]

Closes #33835.

I love fixing issues multiple times.

Notably the refetch is not forced so this should be a no-op if the global state is already correct.

#33835 (comment) says

but we should also consider adding a force RunTask of the pending debounce before entering gameplay, probably around here:

osu/osu.Game/Screens/SelectV2/SongSelect.cs

Line 420 in 3192eaa

selectionDebounce?.Cancel();

but I am not confident in making that change as I have no idea whether it is correct or not.

[peppy]

but I am not confident in making that change as I have no idea whether it is correct or not.

I'd be inclined to make the change as a "makes sense" thing. Basically means song select has the correct beatmap on suspending, rather than potentially on resuming to song select and having it suddenly change. Okay if I add that in this PR? Doesn't seem to break any tests.

diff --git a/osu.Game/Screens/SelectV2/SongSelect.cs b/osu.Game/Screens/SelectV2/SongSelect.cs
index 744c990317..d65a8a49dd 100644
--- a/osu.Game/Screens/SelectV2/SongSelect.cs
+++ b/osu.Game/Screens/SelectV2/SongSelect.cs
@@ -417,6 +417,8 @@ private void detachTrackDucking()
         /// <param name="startAction">The action to perform if conditions are met to be able to proceed. May not be invoked if in an invalid state.</param>
         public void SelectAndRun(BeatmapInfo beatmap, Action startAction)
         {
+            if (selectionDebounce?.State == ScheduledDelegate.RunState.Waiting)
+                selectionDebounce?.RunTask();
             selectionDebounce?.Cancel();
 
             if (!this.IsCurrentScreen())

(Notably, it doesn't fix the issue, likely due to the leaderboard not being in a good state at that point to refetch the scores.)

[bdach]

I mean sure you can add it but I'm not sure I can make much sense of that debounce stuff at all at this stage.

• Nitpick but in your patch, if you're going to run the debounce inline if it's waiting, then why cancel it immediately afterwards?

• Then there's also the other inline debounce execution in ensureGlobalBeatmapValid() that you added yesterday (and which I "smiled and nodded" at as the commit message suggested):

  osu/osu.Game/Screens/SelectV2/SongSelect.cs

  Lines 470 to 471 in 4b66584

  	if (selectionDebounce?.State == ScheduledDelegate.RunState.Waiting)
  	selectionDebounce?.RunTask();

All of this has me in a place where I'm no longer sure of what's going on, or why this is being flushed and where.

[peppy]

You say yesterday, but the only change I can see is last week

873d622

Is this the one you're referring to?

The debounce is only there to stop the statistics on song select from updating too often. The rationale behind forcing it is so things are in a good state before/when leaving the screen.

I'll address this in a separate PR and tidy things up.

[bdach]

You say yesterday, but the only change I can see is last week

873d622

Yeah I guess that's my mistake, authored a week ago, but I reviewed it yesterday.

[peppy]

Scratch that thought completely.

cancel is correct in this usage due to the subsequent highlighted code, which does the same thing as the debounce would have.

I'm still going to try and refactor this because that was not immediately obvious (and should have been).