Fix inconsistent rounding strategy for PP #33830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EYHN
force-pushed
the
eyhn/fix/pp-rounding
branch
from
288acc0 to
c61ec0b
Compare
smoogipoo
previously approved these changes
Jun 24, 2025
|
If we're being pedantic, this was not entirely correct. The reason why is that while applying rounding as it was applied here was correct to match the initial and final values as displayed everywhere else, it would not end up being correct for the delta, as demonstrated in the a78dc31 test (one display would show +1pp, the other would show +2pp). Which I fixed in b1e86aa. Notably while flooring was explicitly introduced in #29512 rather than rounding, I'm fine with rounding because it appears the website is already rounding anyway, so I'm falling in line with everything else rather than inventing new behaviours. |
bdach
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that after a game, the UserStatisticsUpdateDisplay next to the user's avatar directly truncates the decimal places of the PP value instead of rounding it like everywhere else.