Remove fade from footer display transition #33664
Conversation
| RelativeSizeAxes = Axes.X, | ||
| AutoSizeAxes = Axes.Y, |
There was a problem hiding this comment.
Something about these changes is breaking TestSceneScreenFooter (in particular the TestTemporarilyShowFooter test case) and maybe consumers too but I'm not sure what precisely or how to even fix it.
TestSceneMultiplayerMatchSubScreen.TestModSelectOverlay failure also looks possibly related because it looks like the content pops in a slight while later than on master which fails the assert.
There was a problem hiding this comment.
Fixed but I'm not sure you'll like the fix. I know I don't but don't have a better offering for now.
There was a problem hiding this comment.
If you mean 23653b7 then I'm not sure that did anything at all... still red
There was a problem hiding this comment.
I think I posted that on the wrong PR somehow.
| Height = HEIGHT; | ||
|
|
||
| // For masking and transition purposes, take up the full height of displayed buttons. | ||
| Height = ScreenFooterButton.HEIGHT; |
There was a problem hiding this comment.
This causes the other test failure because indiscriminately increasing this height appears to inadvertently cause block input propagation too which leads to dead areas where the footer will never show anything but will also block input:
Screen.Recording.2025-06-12.at.12.01.10.mov
|
Really sorry to keep doing this but mod select overlay looks broke now (the difficulty display stuff is covering the mod button): 
Something to do with messing with the relative size / autosize thing, no doubt. I'm not making any judgement call on the sanity of that code on master either, though. |
Fades should not be used for these kinds of elements. The opacity changes of multiple elements looks shocking. It's unnecessary.
|
I've rewritten this to not touch anything that breaks things because I can't make it work. See what you think. The new approach just disables masking rather than work around it. |
|
|
||
| // Disable masking because it breaks due to the height of this container being less than the displayed content. | ||
| // The height being set as it is is required for transition purposes. | ||
| public override bool UpdateSubTreeMasking() => false; |
There was a problem hiding this comment.
I'm not entirely sure what this is supposed to be fixing (as in I don't see anything break when this is commented out), but I suppose I'll just smile and nod to finally move this forward?
There was a problem hiding this comment.
Here's a video showing the issue:
2025-06-21.19.22.08.mp4
Fades should not be used for these kinds of elements. The opacity changes of multiple elements looks shocking. It's unnecessary.
Before:
osu.Game.Tests.2025-06-12.at.08.05.39.mp4
After:
osu.Game.Tests.2025-06-12.at.08.04.18.mp4