Fix loading spinner without a box clipping #33509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Never would have thought fixing this one would be so simple! |
peppy
approved these changes
Jun 6, 2025
|
The recent commit changed the animation of the one without the box. I don't think it was intentional: Kapture.2025-06-06.at.17.13.03.mp4 |
peppy
added a commit
to peppy/osu
that referenced
this pull request
Jun 16, 2025
Fixes regression mentioned [here](ppy#33509 (comment)). Adjust visuals and metrics slightly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better workaround than the scale that was said in the deleted comment (when that discussion was still an issue). Videos may not show well, so you may have to see it yourself.
Before:
Kapture.2025-06-06.at.08.50.07.mp4
After:
Kapture.2025-06-06.at.08.49.19.mp4