Skip to content

Fix leaderboard score display not respecting local timezone & user 12/24hr settings #33499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jun 6, 2025

Closes #33473.

Cross-reference previous implementation:

timestampLabel.Text = LocalisableString.Format("Played on {0}",
displayedScore.Date.ToLocalTime().ToLocalisableString(prefer24HourTime.Value ? @"d MMMM yyyy HH:mm" : @"d MMMM yyyy h:mm tt"));

@bdach bdach self-assigned this Jun 6, 2025
@bdach bdach added area:song-select type:cosmetic next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! labels Jun 6, 2025
@peppy peppy merged commit 7cfd749 into ppy:master Jun 6, 2025
9 checks passed
@bdach bdach deleted the leaderboard-score-tooltip branch June 6, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:song-select next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/S type:cosmetic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Song Select v2: score leaderboard doesnt respect user's timezone and time display settings
2 participants