-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Description
When a new major release is released, tachyon users will update to it (meaning they are running a "lazer" release stream release – aka non-prerelease github release – even though their preference if for tachyon). Due to the following code, this will update their configuration file to track lazer instead of tachyon:
Lines 1061 to 1063 in 2f37455
// Make sure the release stream setting matches the build which was just run. | |
if (Enum.TryParse<ReleaseStream>(Version.Split('-').Last(), true, out var releaseStream)) | |
LocalConfig.SetValue(OsuSetting.ReleaseStream, releaseStream); |
This code should probably not run for users which have the ability to change their release stream from settings.
Notably, we also have velopack logic to "recover" a user to a correct stream on reinstalling the game from that stream:
osu/osu.Desktop/OsuGameDesktop.cs
Lines 115 to 116 in 9927f62
if (IsFirstRun) | |
LocalConfig.SetValue(OsuSetting.ReleaseStream, ReleaseStream.Lazer); |
This should still work correctly to cover the case where a user's game may not be starting on tachyon and they run the installer from scratch.
cc @smoogipoo since this will involve mobile and package-managed scenarios. if you're able to take this on then that would be appreciated.
As a temporary fix, I've released a no-change tachyon build after the recent major release so tachyon users will update to that instead.