Use :before_send
callback with plugs for sessions
#398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #356 (comment) I discussed how the store might be updated before a response gets aborted. I haven't dug too much into how it all works, but I think this is the proper path after looking at how
Plug.Session
handles writes in the:before_send
callback withPlug.Conn.register_before_send/2
.This PR makes so
PowPersistentSession.Plug.Cookie
andPow.Plug.Session
also uses:before_send
callback for writes.