Skip to content

Add local run script #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 25, 2025
Merged

Add local run script #98

merged 5 commits into from
Mar 25, 2025

Conversation

mudit-postman
Copy link
Contributor

@mudit-postman mudit-postman commented Mar 21, 2025

  • Add Dockerfile and replace-go.sh from the superstar service with tweaks to make Linux arm builds locally. Also added the Makefile command.
  • CODEOWNERS update: Added @mgritter and @cesher as code owners for the repository.

replace-go.sh Outdated
@@ -0,0 +1,22 @@
#!/usr/bin/env bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: Should the local build Dockerfile or utilities like this go in a subdirectory?

@mgritter
Copy link
Contributor

Should CI build this docker image?

@mudit-postman
Copy link
Contributor Author

mudit-postman commented Mar 25, 2025

Should CI build this docker image?

@mgritter What will be the use case of this?

  • Store it somewhere so that everyone can use it?
  • For integration tests?
  • For security scanning?
  • Anything else?

@mudit-postman mudit-postman requested a review from mgritter March 25, 2025 15:39
@mgritter
Copy link
Contributor

I was mainly thinking to test whether the build is still working.

@mudit-postman mudit-postman merged commit 23bbbae into main Mar 25, 2025
4 checks passed
@mudit-postman mudit-postman deleted the mudit/add-local-run-script branch March 25, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants