Fix issues causing RStudio keybindings to be incorrectly shown in some contexts #7362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
melissa-barca
requested changes
Apr 24, 2025
src/vs/workbench/contrib/positronKeybindings/browser/positronKeybindings.contribution.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/positronKeybindings/browser/positronKeybindings.contribution.ts
Show resolved
Hide resolved
| ContextKeyExpr.not('findInputFocussed'), | ||
| ContextKeyExpr.not('replaceInputFocussed') | ||
| ), | ||
| primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.Enter |
There was a problem hiding this comment.
same question here
positron/extensions/positron-rstudio-keymap/package.json
Lines 130 to 132 in 64988df
Comment on lines
266
to
269
| id: 'workbench.view.scm', | ||
| weight: KeybindingWeight.WorkbenchContrib, | ||
| primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.KeyM | ||
| })); |
There was a problem hiding this comment.
WinCtrl here as well?
positron/extensions/positron-rstudio-keymap/package.json
Lines 199 to 204 in 64988df
There was a problem hiding this comment.
good call, updated!
…eybindings.contribution.ts Co-authored-by: Melissa Barca <[email protected]> Signed-off-by: Jonathan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue causing RStudio keybindings to show up in unwanted places. It turns out to be intractable to make extension keybindings work the way we want, so the fix is to delete the extension and move these keybindings into a new "Positron Keybindings" contrib, where we can avoid registering them entirely if they are not enabled.
A few notes:
CmdCtrlresolves toCmdon macOS andCtrlelsewhere). In most cases I have tried to preserve the RStudio behavior by registering both, even though this pollutes the keymap more. (Confusingly enough the Ctrl key on macOS has the identifierWinCtrlin VS Code.)Addresses #3993.
Release Notes
New Features
Bug Fixes
QA Notes
As noted in the setting, a restart is required to get these bindings to become active.