feat: Add fmt_image_circle()
and vals.fmt_image_circle()
functions
#676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team,
This PR addresses #354.
Rather than modifying the existing
fmt_image()
to accommodate border-related parameters, I have renamed the currentfmt_image()
to_fmt_image()
, and introduced newfmt_image()
andfmt_image_circle()
functions as thin wrappers around it. Keeping_fmt_image()
andFmtImage
under our control gives us greater flexibility to add more parameters in the future if needed.Here’s a short demo to illustrate the usage:
One thing that seems odd to me is that
NotImplementedError
doesn’t appear to be raised as expected during execution, yet our tests still pass.For instance, when running the following code, I would expect it to break, but instead, the print statement after
vals.fmt_image()
is executed successfully, which feels strange.