-
Notifications
You must be signed in to change notification settings - Fork 7
Add openai as a hard dependency #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR changes the dependency management by adding openai as a hard dependency so that all chat provider modules no longer require separate installation instructions for openai. Key changes include:
- Adding "openai" to the core dependencies in pyproject.toml.
- Removing redundant installation callout notes and try/except blocks for the openai package in multiple provider files.
- Updating provider extras in pyproject.toml to empty lists for modules that previously listed openai.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
pyproject.toml | Adds openai as a hard dependency and updates provider extras to reflect the change. |
chatlas/_perplexity.py | Removes openai installation guidance from the documentation callout. |
chatlas/_openai.py | Eliminates the try/except ImportError block and related callout notes. |
chatlas/_ollama.py | Removes openai installation instructions from documentation callout. |
chatlas/_groq.py | Removes redundant openai requirement callouts from documentation. |
chatlas/_github.py | Removes openai installation instructions from documentation callout. |
chatlas/_databricks.py | Updates the package installation message and removes try/except block for openai. |
databricks = ["databricks-sdk[openai]"] | ||
github = ["openai"] | ||
databricks = ["databricks-sdk"] | ||
github = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since openai is now a hard dependency, consider adding a comment in pyproject.toml explaining that the provider extras such as 'github', 'groq', 'ollama', etc. are intentionally left empty.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh, I kinda agree with Copilot! That's a first 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the diff very clearly demonstrates that this is a good choice!
Adds
openai
as a hard dependency so that a handful of chat providers can be used without an additional install. This also helps avoid a confusing install error when tools are used.Closes #22