Use a clearly synthetic filename when compiling code #593 #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using just the source as the file name confuses tools like coverage.py that analyze code execution. Using angle brackets makes clear that this is not a real file.
This was referenced Mar 19, 2021
|
Any opinions on this? |
|
Hello, sorry for a long reply. Thanks for your Pull Request. |
kozlovsky
added a commit
that referenced
this pull request
Jan 10, 2022
# Features * Add Python 3.10 support, drop support of Python < 3.7 # Bugfixes * Do not perform optimistic checks when deleting an object (it is OK if it was already deleted by concurrent transaction) * Validation of int fields should take into account field size and check that the value is fit into the range * More tests for hybrid methods added * Fix incorrect assertion check `assert t is translator.` * Fix aggregated query `sum(x.field for x in previous_query)` * #594: Use a clearly synthetic filename when compiling dynamic code to not confuse coverage.py * Use DecompileError exception instead of AssertionError when a function cannot be decompiled
kozlovsky
added a commit
that referenced
this pull request
Jan 27, 2022
# Features * Add Python 3.10 support, drop support of Python < 3.7 * You can create an in-memory SQLite database accessible from multiple threads by specifying ":sharedmemory:" as a file name # Bugfixes * Do not perform optimistic checks when deleting an object (it is OK if it was already deleted by concurrent transaction) * Validation of int fields should take into account field size and check that the value is fit into the range * More tests for hybrid methods added * Fix incorrect assertion check `assert t is translator.` * Fix aggregated query `sum(x.field for x in previous_query)` * #594: Use a clearly synthetic filename when compiling dynamic code to not confuse coverage.py * Use DecompileError exception instead of AssertionError when a function cannot be decompiled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using just the source as the file name confuses tools like coverage.py
that analyze code execution. Using angle brackets makes clear that this
is not a real file.