Convert only DB Engine's commit() exceptions to CommitException #159
Comments
kozlovsky
added a commit
that referenced
this issue
Oct 11, 2016
Starting with this release Pony ORM is release under the Apache License, Version 2.0. # New features * Added getattr() support in queries: https://docs.ponyorm.com/api_reference.html#getattr # Backward incompatible changes * #159: exceptions happened during flush() should not be wrapped with CommitException Before this release an exception that happened in a hook(https://docs.ponyorm.com/api_reference.html#entity-hooks), could be raised in two ways - either wrapped into the CommitException or without wrapping. It depended if the exception happened during the execution of flush() or commit() function on the db_session exit. Now the exception happened inside the hook never will be wrapped into the CommitException. # Bugfixes * #190: Timedelta is not supported when using pymysql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In other words, exceptions, raised in hooks (like post-insert ones) must not be wrapped into
CommitExceptionanymore.This is not backward-compatible change, so please mention that in documentation (refer to versions), and also describe new behaviour in docs.
The text was updated successfully, but these errors were encountered: