Skip to content

refactor: Move to all optimization flags to QueryOptFlags #22680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 9, 2025

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels May 9, 2025
@coastalwhite coastalwhite requested a review from orlp as a code owner May 9, 2025 13:02
@coastalwhite coastalwhite force-pushed the refactor/query-opt-flags branch from cee8645 to e7f6f5d Compare May 9, 2025 13:25
@coastalwhite
Copy link
Collaborator Author

There is an issue in the test suite here and I am so lost on what it is.

@coastalwhite coastalwhite force-pushed the refactor/query-opt-flags branch from b131cea to 115eea0 Compare May 9, 2025 18:22
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 88.52459% with 28 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (897fa07) to head (7e8f05f).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/lazyframe/opt_flags.py 76.41% 23 Missing and 2 partials ⚠️
py-polars/polars/dataframe/group_by.py 90.00% 1 Missing ⚠️
py-polars/polars/functions/eager.py 66.66% 1 Missing ⚠️
py-polars/polars/functions/lazy.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22680      +/-   ##
==========================================
+ Coverage   81.01%   81.03%   +0.02%     
==========================================
  Files        1665     1666       +1     
  Lines      235629   236026     +397     
  Branches     2774     2797      +23     
==========================================
+ Hits       190891   191270     +379     
- Misses      44070    44081      +11     
- Partials      668      675       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coastalwhite coastalwhite merged commit 2927ed1 into pola-rs:main May 9, 2025
27 checks passed
@coastalwhite coastalwhite deleted the refactor/query-opt-flags branch May 9, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant