chore: Only use pytorch index-url for pytorch package
#22355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
mcrumiller
commented
Apr 21, 2025
| @@ -93,6 +93,7 @@ jobs: | |||
| uses: actions/setup-python@v5 | |||
| with: | |||
| python-version: '3.12' | |||
| check-latest: true | |||
There was a problem hiding this comment.
This also ensures we're testing on the latest python 3.12, which is now 3.12.10 (our CI had 3.12.9 cached and was continuing to use that).
mcrumiller
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
mcrumiller
changed the title
pytorch packagepytorch package
ritchie46
reviewed
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I am not 100% sure I have done this right so someone more familiar with project setup please review!
While
trying to fix(whoops, triggered issue close keyword) work on #22348 (with no success so far), I discovered that by using--extra-index-urlinrequirements-ci.txtpolars/py-polars/requirements-ci.txt
Line 5 in 3cfa7cd
we were inadvertently using the pytorch repo for many package installations, including numpy, since when you use
--extra-index-urlit becomes prioritized (see docs) over PyPi. This was causing packages to be installed from pytorch instead of PyPi, and subsequently was not installing the latest version. For example, pytorch's latest availablenumpyis 2.1.2, whereas PyPi has 2.2.5.I believe this helps ensure we're testing on the latest version of more packages. @MarcoGorelli I think I saw your comment on an issue somewhere so I think you may have helped set up the extra-index-url bit, is that true?