Skip to content

fix: Expression pl.concat was incorrectly marked as elementwise #22019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 1, 2025

Conversation

orlp
Copy link
Member

@orlp orlp commented Apr 1, 2025

Fixes #21980.
Fixes #19877.

Also fixes an issue that wasn't reported (to my knowledge) with pl.concat in group_by.

@orlp orlp changed the title fix: pl.concat was incorrectly marked as elementwise fix: Expression pl.concat was incorrectly marked as elementwise Apr 1, 2025
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Apr 1, 2025
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.90%. Comparing base (90094f0) to head (9243bd4).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22019      +/-   ##
==========================================
- Coverage   80.99%   80.90%   -0.09%     
==========================================
  Files        1638     1639       +1     
  Lines      236856   236863       +7     
  Branches     2696     2696              
==========================================
- Hits       191840   191643     -197     
- Misses      44382    44586     +204     
  Partials      634      634              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@orlp orlp merged commit 4dd8b47 into pola-rs:main Apr 1, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

concat of columns creates extra rows if engine="streaming" pl.concat() output with Expr input is wrong when using the new streaming engine
1 participant