fix: Fix collect_all type-coercion #21810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
requested review from
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21810 +/- ##
=======================================
Coverage 81.10% 81.10%
=======================================
Files 1613 1613
Lines 233269 233270 +1
Branches 2688 2688
=======================================
+ Hits 189197 189202 +5
+ Misses 43442 43438 -4
Partials 630 630 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsjasonseba
pushed a commit
to jsjasonseba/polars
that referenced
this pull request
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@coastalwhite FYI.
Might we worth a patch given that running a query without type-coercion is utterly broken.
fixes #21805
fixes #21794
fixes #21791