Skip to content

fix: Clear NaNs due to zero-weight division in rolling var/std #21761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2025

Conversation

orlp
Copy link
Member

@orlp orlp commented Mar 14, 2025

Fixes #21758.

@orlp orlp requested review from ritchie46 and c-peters as code owners March 14, 2025 22:01
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Mar 14, 2025
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.13%. Comparing base (d671d3c) to head (c42eb34).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21761      +/-   ##
==========================================
+ Coverage   81.06%   81.13%   +0.06%     
==========================================
  Files        1610     1612       +2     
  Lines      233050   233373     +323     
  Branches     2689     2687       -2     
==========================================
+ Hits       188927   189340     +413     
+ Misses      43492    43403      -89     
+ Partials      631      630       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ritchie46 ritchie46 merged commit 12b8ee7 into pola-rs:main Mar 15, 2025
26 checks passed
jsjasonseba pushed a commit to jsjasonseba/polars that referenced this pull request Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with rolling_std producing NaNs in 1.24
2 participants