Skip to content

refactor: Introduce a Sink Node trait in the new streaming engine #21458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

coastalwhite
Copy link
Collaborator

This will wrap all the sink nodes and allow generic functionality using the sink nodes.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 0.44643% with 446 lines in your changes missing coverage. Please review.

Project coverage is 79.99%. Comparing base (c37e482) to head (8427e9e).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/io_sinks/mod.rs 0.00% 151 Missing ⚠️
crates/polars-stream/src/nodes/io_sinks/parquet.rs 0.00% 98 Missing ⚠️
crates/polars-stream/src/nodes/io_sinks/ipc.rs 0.00% 90 Missing ⚠️
crates/polars-stream/src/nodes/io_sinks/csv.rs 0.00% 60 Missing ⚠️
crates/polars-stream/src/nodes/io_sinks/json.rs 0.00% 46 Missing ⚠️
crates/polars-stream/src/nodes/io_sources/mod.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21458      +/-   ##
==========================================
- Coverage   80.02%   79.99%   -0.03%     
==========================================
  Files        1597     1598       +1     
  Lines      229111   229196      +85     
  Branches     2620     2620              
==========================================
+ Hits       183338   183347       +9     
- Misses      45174    45250      +76     
  Partials      599      599              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite merged commit 28cc37a into pola-rs:main Feb 25, 2025
22 checks passed
@coastalwhite coastalwhite deleted the refactor/new-streaming-sink-node branch February 25, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant