Skip to content

perf: Reduce arrow slice mmap overhead #21113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

orlp
Copy link
Member

@orlp orlp commented Feb 6, 2025

The owner-based arrow array backing is rather slow to create, we already have a static slice storage backing in SharedStorage we can use.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.28%. Comparing base (e89987d) to head (b93f149).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-arrow/src/ffi/mmap.rs 33.33% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21113      +/-   ##
==========================================
+ Coverage   79.21%   79.28%   +0.07%     
==========================================
  Files        1589     1589              
  Lines      226497   226509      +12     
  Branches     2594     2594              
==========================================
+ Hits       179420   179598     +178     
+ Misses      46481    46315     -166     
  Partials      596      596              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlp orlp merged commit 809e4fb into pola-rs:main Feb 6, 2025
24 checks passed
@c-peters c-peters added the accepted Ready for implementation label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants