fix: Revert length check of patterns in str.extract_many()
#20953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
This comment was marked as outdated.
This comment was marked as outdated.
etiennebacher
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20953 +/- ##
==========================================
- Coverage 79.30% 79.29% -0.01%
==========================================
Files 1578 1578
Lines 224156 224199 +43
Branches 2576 2573 -3
==========================================
+ Hits 177762 177786 +24
- Misses 45803 45825 +22
+ Partials 591 588 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20962.
This was introduced in #20781 and noticed here: #20781 (comment). Thanks @eitsupi.
Like other
str.*_many()functions,str.extract_many()shouldn't check the length of thepatternsarg.This was overlooked in the tests because the main test for
extract_many()only had one value and one list ofpatterns. I updated it to ensure that lengths of input andpatternscan be different. Sorry for the mistake.