Skip to content

feat: Add hint for POLARS_AUTO_USE_AZURE_STORAGE_ACCOUNT_KEY to error message #20942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Jan 28, 2025

  • Adds a hint to set the environment variable POLARS_AUTO_USE_AZURE_STORAGE_ACCOUNT_KEY in the error message if it is unset and a cloud operation to Azure fails.
  • CredentialProviderAzure is now auto-initialized if the above is set (and we are able to successfully retrieve the keys) regardless of whether azure.identity is not installed, as in this case we don't use the library.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jan 28, 2025
@nameexhaustion nameexhaustion changed the title feat: Add hint for POLARS_AUTO_USE_AZURE_STORAGE_ACCOUNT_KEY feat: Add hint for POLARS_AUTO_USE_AZURE_STORAGE_ACCOUNT_KEY to error message Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 38.70968% with 19 lines in your changes missing coverage. Please review.

Project coverage is 79.30%. Comparing base (6a3fc59) to head (25d9056).
Report is 57 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-io/src/cloud/polars_object_store.rs 28.57% 10 Missing ⚠️
py-polars/polars/io/cloud/credential_provider.py 35.71% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20942      +/-   ##
==========================================
- Coverage   79.30%   79.30%   -0.01%     
==========================================
  Files        1578     1578              
  Lines      224135   224156      +21     
  Branches     2574     2576       +2     
==========================================
+ Hits       177751   177758       +7     
- Misses      45793    45807      +14     
  Partials      591      591              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review January 28, 2025 08:00
@ritchie46 ritchie46 merged commit 3def63b into pola-rs:main Jan 28, 2025
29 checks passed
@c-peters c-peters added the accepted Ready for implementation label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants