fix: Fix panic InvalidHeaderValue scanning from S3 on Windows
#20820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
force-pushed
the
aws-creds-panic-windows
branch
from
7aa1e1a to
ebf5606
Compare
nameexhaustion
commented
Jan 21, 2025
| AmazonS3ConfigKey::SecretAccessKey, | ||
| ), | ||
| ( | ||
| "aws_session_token\\s*=\\s*([^\\r\\n]*)", |
There was a problem hiding this comment.
drive-by load the session token if it exists
nameexhaustion
requested review from
ritchie46,
orlp and
c-peters
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20820 +/- ##
=======================================
Coverage 79.69% 79.69%
=======================================
Files 1568 1568
Lines 222969 222977 +8
Branches 2544 2544
=======================================
+ Hits 177696 177703 +7
- Misses 44689 44690 +1
Partials 584 584 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Jan 21, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20650
Issue is due to not handling the carriage return
\rof the CRLF\r\nline terminator used in the configuration file.This updates Rust-side code, however it is less-used after the Python-side CredentialProviderAWS was introduced.