Skip to content

feat: Update sqlparser-rs, enabling "LEFT" keyword to be optional for anti/semi joins in SQL queries #20576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Jan 6, 2025

Closes #20546, upgrading sqlparser-rs to version0.53 and taking advantage of some anti/semi join-parsing updates.

The following SQL queries are now both valid for use with Polars, and are equivalent (the "LEFT" keyword becomes implicit if omitted, as per other dialects such as DuckDB):

SELECT * FROM tbl_a LEFT SEMI JOIN tbl_b USING (a,b,c)
SELECT * FROM tbl_a SEMI JOIN tbl_b USING (a,b,c)

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.98%. Comparing base (11dd4b3) to head (804944f).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-sql/src/functions.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #20576       +/-   ##
===========================================
+ Coverage   58.69%   78.98%   +20.28%     
===========================================
  Files        1564     1564               
  Lines      220765   220770        +5     
  Branches     2504     2504               
===========================================
+ Hits       129584   174373    +44789     
+ Misses      90607    45823    -44784     
  Partials      574      574               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-beedie alexander-beedie added the A-sql Area: Polars SQL functionality label Jan 7, 2025
@ritchie46 ritchie46 merged commit bf550bc into pola-rs:main Jan 7, 2025
33 checks passed
@alexander-beedie alexander-beedie deleted the update-sqlparser branch January 7, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql Area: Polars SQL functionality enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump sqlparser to 0.53.0
2 participants